Add custom fonts support for Unicode PDFs #634
+41
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kunal-595 <[email protected]>
ekarademir
reviewed
Oct 22, 2025
packages/markdown-pdf/index.js
Outdated
|
|
||
| module.exports.PdfTransformer = require('./lib/PdfTransformer'); | ||
| module.exports.ToPdfMake = require('./lib/ToPdfMake'); | ||
| module.exports.defaultFonts = require('./lib/pdfmakeutil').defaultFonts; |
There was a problem hiding this comment.
Suggested change
| module.exports.defaultFonts = require('./lib/pdfmakeutil').defaultFonts; | |
| module.exports.DefaultFonts = require('./lib/pdfmakeutil').defaultFonts; |
There was a problem hiding this comment.
Thanks ,I changed the export to DefaultFonts and updated the README example .The PR has been updated. Please let me know if you'd like any additional changes.
Signed-off-by: kunal-595 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455
This PR adds support for custom Unicode fonts in PDF generation, allowing users to render Unicode characters (Arabic, Chinese, Japanese, etc.) by providing their own font files.
Changes
PdfTransformerBase.jsto accept an optionalfontsparameter inpdfMakeToPdfStreamWithCallback()andpdfMakeToPdfStream()methodsPdfTransformer.jsto accept and pass through thefontsparameter inpdfMakeToPdfBuffer()methoddefaultFontsfrompackages/markdown-pdf/index.jsto allow users to extend the default Liberation fontspackages/markdown-pdf/README.mdwith usage examples showing how to use custom Unicode fontsFlags
fontsparameter is optional and defaults to existing Liberation fontsScreenshots or Video
N/A - API enhancement for font support
Related Issues
Author Checklist
--signoffoption of git commit.